-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gh cli call to deploy of HybridApp when we deploy staging NewExpensify #43080
Conversation
.github/workflows/platformDeploy.yml
Outdated
if: ${{ fromJSON(needs.validateActor.outputs.IS_DEPLOYER) }} | ||
steps: | ||
- name: 'Deploy HybridApp' | ||
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this if
to the job level and combine them?
@s77rt no C+ review needed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change. I imagine we might see more 'App deploy' build pings in Slack and on the GH issues? Not a problem, but if noisy maybe we can figure out how to clarify this in the failure message that is posted to Slack.
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Add gh cli call to deploy of HybridApp when we deploy staging NewExpensify (cherry picked from commit ba5d793)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 1.4.79-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
|
Details
We tried to deploy HybridApp (From the Mobile-Deploy repo) using a re-useable workflow, but it seems like that isn't supported by GitHub. This change will call the workflow, but not have the nice re-useable workflow UI.
Fixed Issues
$ #37858
Tests
gh workflow run --repo Expensify/Mobile-Deploy deploy.yml -f force_build=true
from my local machine started the correct build with the force build flag enabled.QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A
MacOS: Desktop
N/A